Added method to get query string parameters insignificant of order#36
Added method to get query string parameters insignificant of order#36khaliddermoumi wants to merge 3 commits intotavis-software:mainfrom
Conversation
…ends on order of parameters
…meters()" that ignores the order of query parameters. Note that this method returns an empty dictionary instead of null when no match is found. Plus some unit tests.
|
Darell, |
|
Thanks for this PR. Unfortunately, it is hard to review the changes because it appears that every line seems to have changed in the URITemplate class. I will try and look again later today. |
|
Hi Darell, my Visual Studio wanted to indent the lines evenly (a part of the class was indented with 4 spaces less than the rest). The github UI doesn't "ignore whitespace" in diffs. Regards |
|
How about it, Darell? Any plans to make a change here? |
|
@khaliddermoumi Sorry for going dark. Yes, I'd like to incorporate this change as part of a bigger fix. It turns out there is an issue with parsing arrays of values, reported by Anthony from Glimpse. Depending on where the parameter is in the URITemplate there are different delimiters that are allowed. Therefore I am going to have to split the URL into authority, path, query and fragment in order to do parameter matching. This will allow me to apply different rules to the query. |
|
Thx Darrel! |
Hi Darell!
Finally I made the change we discussed recently. Notes:
Regards,
Khalid