values: support physical placeholders #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a physical placeholders support for `ValuesExec`.
1) Planner keeps a flag that tells whether there are placeholders
within a Values Logical Plan. This is known when SQL is turning
into the logical plan.
2) This flag is updated each time when expressions are mapped.
3) On the physical planning stage this flag is passed into
`ValuesExec` constructor.
4) `ValuesExec` now has 2 work modes:
(a) When an input batch is resolved. It do the same as before.
(b) When it is known that an input batch contains placeholders.
Then placeholders will be resolved in execution time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a physical placeholders support for
ValuesExec.Planner keeps a flag that tells whether there are placeholders
within a Values Logical Plan. This is known when SQL is turning
into the logical plan.
This flag is updated each time when expressions are mapped.
On the physical planning stage this flag is passed into
ValuesExecconstructor.ValuesExecnow has 2 work modes:(a) When an input batch is resolved. It do the same as before.
(b) When it is known that an input batch contains placeholders.
Then placeholders will be resolved in execution time.