Skip to content

Added new svg icon with "context-fill" #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichelePezza wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added new svg icon with "context-fill" #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions assets/images/sidebar-logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
"manifest_version": 2,
"name": "Checkmarks",
"description": "Checks, sorts, formats bookmarks and loads favicons.",
"version": "1.6.1",
"version": "1.6.2",
"icons": {
"48": "assets/images/logo.svg",
"96": "assets/images/logo.svg"
},
"sidebar_action": {
"default_icon": "assets/images/icon-light.svg",
"default_icon": "assets/images/sidebar-logo.svg",
"default_title": "Checkmarks",
"default_panel": "sidebar/checkmarks-sidebar.html"
},
Expand Down
16 changes: 0 additions & 16 deletions sidebar/checkmarks-sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ function CheckmarksSidebar() {
*/
this.init = function () {
console.debug('DEBUG: Initializing...');
setIcon();
setFilters();
restoreRun();
// Start button that initializes the chain of events.
Expand Down Expand Up @@ -217,21 +216,6 @@ function CheckmarksSidebar() {
})
};

let setIcon = function () {
const isDarkScheme = window.matchMedia('(prefers-color-scheme: dark)').matches;
console.info(`INFO: Dark color scheme: ${isDarkScheme}.`);

browser.sidebarAction.setIcon({
path: isDarkScheme ? {
16: '/assets/images/icon-light.svg',
32: '/assets/images/icon-light.svg'
} : {
16: '/assets/images/icon-dark.svg',
32: '/assets/images/icon-dark.svg'
}
}).then(() => console.info('INFO: Icon set.'));
};

/**
* Restores options from local storage or sets default values.
* @param options {{}} Options map from local storage.
Expand Down