fix(sitemap): skip external slugs and guard invalid dates#3806
Merged
tangly1024 merged 2 commits intotangly1024:mainfrom Apr 30, 2026
Merged
fix(sitemap): skip external slugs and guard invalid dates#3806tangly1024 merged 2 commits intotangly1024:mainfrom
tangly1024 merged 2 commits intotangly1024:mainfrom
Conversation
|
@qianzhu18 is attempting to deploy a commit to the tangly1024's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Heads-up: Vercel checks are failing with "Authorization required to deploy" from my fork environment. I verified this change locally with targeted lint/tests listed in the PR description. |
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes sitemap URL generation when menu/page slugs are external links, and guards invalid
publishDayvalues to avoid invalid date output.Closes #3668
Problem
slugwere appended to site domain, producing invalid URLs like:https://example.com/https://external.com/pageInvalid Datebehavior into sitemap generation paths.Root Cause
toISOString()without invalid-date fallback.Changes
lib/sitemap-utils.jsfor shared sitemap normalization:pages/sitemap.xml.jsto use normalized URL/date helpers.lib/sitemap.xml.jswith the same guards.__tests__/lib/sitemap-utils.test.js__tests__/lib/sitemap.xml.test.jsVerification
npm test -- __tests__/lib/sitemap-utils.test.js __tests__/lib/sitemap.xml.test.jsnpm run lint -- --file pages/sitemap.xml.js --file lib/sitemap.xml.js --file lib/sitemap-utils.js --file __tests__/lib/sitemap-utils.test.js --file __tests__/lib/sitemap.xml.test.jsRisk & Compatibility