Deprecate the ignored traversal flag - #82
Merged
Merged
Conversation
Co-authored-by: SihanTeng <SihanTeng@users.noreply.github.com>
tamnd
force-pushed
the
fix/deprecate-traversal
branch
from
August 10, 2026 06:41
f08972e to
44b38a2
Compare
Owner
|
Deprecating rather than removing was the right call, this keeps existing scripts working. I squashed onto main and resolved the cli.md conflict with #76 by keeping its --exclude wording alongside your --traversal row. Worth knowing that MarkDeprecated also hides the flag from clone --help, which I checked on the merged tree and is what we want here since the docs table still lists it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--traversalaccepted so existing scripts continue to run.--traversal dfsparsing.Why
This is the flag cleanup split out of #76 as requested in review. The flag was never read, but deleting it immediately would turn previously successful commands into
unknown flagfailures.Test plan
go test -count=1 ./cli/ ./clone/ -run TestTraversalFlagRemainsAcceptedButDeprecated