Skip to content

Deprecate the ignored traversal flag - #82

Merged
tamnd merged 1 commit into
tamnd:mainfrom
SihanTeng:fix/deprecate-traversal
Aug 10, 2026
Merged

Deprecate the ignored traversal flag#82
tamnd merged 1 commit into
tamnd:mainfrom
SihanTeng:fix/deprecate-traversal

Conversation

@SihanTeng

Copy link
Copy Markdown
Contributor

Summary

  • Keep --traversal accepted so existing scripts continue to run.
  • Mark it deprecated and explain that the crawl is always breadth-first.
  • Document the compatibility period and add a regression test for --traversal dfs parsing.

Why

This is the flag cleanup split out of #76 as requested in review. The flag was never read, but deleting it immediately would turn previously successful commands into unknown flag failures.

Test plan

  • go test -count=1 ./cli/ ./clone/ -run TestTraversalFlagRemainsAcceptedButDeprecated

Co-authored-by: SihanTeng <SihanTeng@users.noreply.github.com>
@tamnd
tamnd force-pushed the fix/deprecate-traversal branch from f08972e to 44b38a2 Compare August 10, 2026 06:41
@tamnd

tamnd commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Deprecating rather than removing was the right call, this keeps existing scripts working. I squashed onto main and resolved the cli.md conflict with #76 by keeping its --exclude wording alongside your --traversal row. Worth knowing that MarkDeprecated also hides the flag from clone --help, which I checked on the merged tree and is what we want here since the docs table still lists it.

@tamnd
tamnd merged commit 0b4eeda into tamnd:main Aug 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants