Skip to content

Conversation

vemoo
Copy link

@vemoo vemoo commented Apr 12, 2025

fixes #333

Initially I deleted some files from test-data/invalid and tried to regenerate crates/taplo/src/tests/generated/invalid.rs by running cargo run --manifest-path ./util/test-gen/Cargo.toml -- -i test-data -o crates/taplo/src/tests/ but it doesn't match the existing file, so I edited crates/taplo/src/tests/generated/invalid.rs by hand.

It may be a good idea consider using https://github.com/toml-lang/toml-test to test the parser.

@vemoo
Copy link
Author

vemoo commented Apr 12, 2025

It may be a good idea consider using https://github.com/toml-lang/toml-test to test the parser.

😅. I see it's used on CI. I was just testing with cargo test. Will take a look at the toml-test failures.

@vemoo
Copy link
Author

vemoo commented Apr 12, 2025

The issue was that toml-test 1.1.0 only supports TOML 1.0. I have updated the CI workflow to use 1.5.0 and TOML 1.1.0 but the issue now is that there are other tests failing not related to the changes on this PR.

Those tests should probably be fixed in a separate PR. They can be skipped when invoking toml-test, and un-skip them in later PR or leave them failing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line breaks and trailing comma in inline tables
1 participant