Skip to content

Conversation

@Yue-Zhou1
Copy link
Collaborator

modularize agent core, cache market client, and optimize SQLite polling

@Yue-Zhou1
Copy link
Collaborator Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +12 to +13
pub use boundless::{AgentError, AgentResult, BoundlessProver, ProverConfig};
pub use types::{AsyncProofRequest, ProofRequestStatus, ProofType, Risc0Response};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore DeploymentType export for tests

The crate root no longer re-exports DeploymentType, but the test module at the bottom of src/main.rs imports everything via use super::* and calls DeploymentType::from_str in its assertions. With the export removed, cargo test will now fail to compile with “cannot find type DeploymentType in this scope” because the type is not brought into the test namespace. Please re-export DeploymentType (or adjust the test imports) so the test suite builds again.

Useful? React with 👍 / 👎.

Comment on lines +51 to +53
- `GET /requests`: List active requests.
- `POST /retry/{request_id}`: Manually retry a failed request using stored input/config.
- `DELETE /requests`: Delete all stored requests.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge README advertises endpoints that the router does not expose

The README now lists POST /retry/{request_id} and DELETE /requests as available endpoints, but the router still registers POST /proof/:request_id/retry and DELETE /prune (see src/main.rs lines 210–216). Clients following the README will hit 404s for retries or pruning. Please align the documented paths with the actual routes (or vice versa) so the published API surface matches the server.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants