Upgrade Django to 6 and refactor dependencies and tests#232
Open
nofalx wants to merge 20 commits into
Open
Conversation
…ce not to be attached correctly
nofalx
commented
Mar 26, 2026
|
|
||
| And here is an inevitably incomplete list of MUCH-APPRECIATED CONTRIBUTORS, people who have submitted patches, reported bugs, added translations, helped answer newbie questions, and generally made Taiga that much better: | ||
|
|
||
| - Ahmad Nofal <nofal.ahmad@outlook.com> |
nofalx
commented
Mar 26, 2026
Comment on lines
+107
to
+108
| # TODO: double check why without create=True the tests fail when doing `pytest -v -n auto` | ||
| refval, _ = make_reference(instance, instance.project, create=True) |
Author
There was a problem hiding this comment.
Running tests in parallel will error out without adding this option, is this additon ok?
nofalx
commented
Mar 26, 2026
Comment on lines
+50
to
+51
| # TODO Prefetching history_entry is currently causing errors. The actual data is fetched from history_service.get_history_queryset_by_model_instance(). Needs confirmation | ||
| value = value.prefetch_related('attachments') |
Author
There was a problem hiding this comment.
In past versions incorrect prefetch fields used to fail silently, I had to remove this as it was doing nothing and causing an error. It seems the "prefetch" logic was already handle by get_history_queryset_by_model_instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all tests are passing, this should help close any security gaps and closes #195
This PR is built on top the work of #229