Skip to content

Conversation

SouthFox-D
Copy link

Is something missing here?

@perfectra1n
Copy link

I really thought I was losing my sanity, thank you for finding this lol.

@dvdsk
Copy link
Contributor

dvdsk commented Oct 22, 2024

Is this still needed given #260? I applied that to my fork and the expiration dropdown is now working without merging this pr. What is the difference between #260 and this?

@perfectra1n
Copy link

@dvdsk this PR allows for the option "never" to appear when the environment variable MICROBIN_ETERNAL_PASTA=true is provided. #260 fixes the behavior of the "never" option when selected. At least that's what I've gathered by looking at the "Files changed" for a quick minute.

@dvdsk
Copy link
Contributor

dvdsk commented Oct 22, 2024

the strange thing is, in my fork (dev branch): https://github.com/dvdsk/microbin/tree/dev I have merged only #260 and the never option now appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants