chore(firecracker): re-enable vsock telemetry forwarding #5729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change re-enables the stream forwarder in Cyclone and the listener in Veritech, both of which help are used to forward OpenTelemetry data out of a Firecracker VM.
Prior to disabling these tasks, it was unclear whether the spawned tokio tasks would naturally terminate on their own, or whether they would continue to run even as more Firecracker instances were spawing in Pool Noodle's pool. This change attempts to tie the lifetime of these forwarding tasks to the lifetime of the Firecracker instance (that is the termination of the VM should also trigger the shutdown of the forwarding task).