journal: replace truncating with punching holes (v252) #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let's automatically destroy test dirs, instead of manually. (cherry picked from commit 951174e)
(cherry picked from commit ff95b60)
… more than once Previously, if journal_file_set_offline() is called twice with 'wait = false', the second call triggered segfaults, as the offline_state is OFFLINE_DONE, and journal_file_set_offline_thread_join() tries to call pthread_join() with NULL. (cherry picked from commit 46e98df)
It seems truncating might cause SIGBUS (#24320). Let's play it safe and always prefer punching holes over truncating. (cherry picked from commit f20c07d)
The added code fails without the previous commit. For issue #24320. (cherry picked from commit 3b0ae13)
orgads
changed the title
Author
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of systemd/systemd#29456 (systemd/systemd#24320) to stable.
Fixes: