power: Do not reset KBLED state on CPU wake #344
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Arguably, a function called "reset" should put the backlight level and color in a known state. But what do bonw14, darp5, and oryp5 actually need to do for I2C when waking the CPU? Does |
crawfxrd
force-pushed
the
kbled-reset
branch
2 times, most recently
from
8471500 to
324ff5c
Compare
Contributor
|
In my tinkering this appeares to break the system76-acpi-dkms module, making the LEDs unusable with the hardware controls inside Linux. If you remove the module they begin to work again. |
Contributor
|
I may have spoken too soon... if I was wrong, I'll post about it again here...but seems my distro is not using the master branch. |
Contributor
|
So it does not appear to be this commit, however the current master does seem to break things with the keyboard backlight controls when the acpi module is in use. |
Do not reset the keyboard backlight on CPU wake. This fixes keyboard backlight turning off and becoming white on wake from sleep. Signed-off-by: Tim Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not reset the keyboard backlight on CPU wake. This fixes keyboard backlight turning off and becoming white on wake from sleep.
TODO: Fix for all kbled mechanisms.