v3.0 upgrade curl to v8.14.0

[mirostauder]

implements ticket #4967

[gemini-code-assist]

Hello @mirostauder, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello everyone, Gemini here with a summary of this pull request. The primary goal of this PR, as indicated by the title and description, is to upgrade the curl dependency to version 8.14.0. This upgrade is part of the v3.0 effort and addresses ticket #4967. The changes involve updating the recorded version string and making minor adjustments to the build process in the Makefile, specifically related to how dependency source directories are linked.

Highlights

• Dependency Upgrade: The core change is the upgrade of the curl library to version 8.14.0.
• Build Process Adjustment: The Makefile build steps for both curl and clickhouse-cpp dependencies have been slightly modified to use the ln -fsT command for creating symbolic links to the extracted source directories. The -T flag ensures the target is treated as a non-directory.
• Version Tracking: The file deps/curl/curl has been updated to reflect the new curl version 8.14.0.

Changelog

• deps/Makefile
  • Modified the symbolic link command for the curl build target (line 122) to use ln -fsT instead of a commented-out configure command.
  • Modified the symbolic link command for the clickhouse-cpp build target (line 162) to use ln -fsT instead of ln -fs.
• deps/curl/curl
  • Updated the version string from curl-8.4.0 to curl-8.14.0/ (line 1).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Dependencies grow old,
New versions, brave and bold,
Update the build,
With code fulfilled,
No more bugs, we're told.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates curl to version 8.14.0 and makes related adjustments to the deps/Makefile. The changes appear to be well-targeted for the version upgrade.

Overall, the modifications are clean and improve the robustness of the dependency handling in the Makefile, particularly with the consistent use of ln -fsT for creating symbolic links to versioned directories. This is a good practice.

The update to a newer version of curl is beneficial for keeping dependencies current, which often includes security fixes and new features.

No issues of medium, high, or critical severity were identified in the provided diffs.

Summary of Findings

• Makefile improvements: The changes in deps/Makefile to use ln -fsT for creating symbolic links (e.g., curl pointing to curl-8.14.0) are a good improvement. The -T option enhances robustness by ensuring the link is created as specified, even if a directory with the same name as the link already exists. This was applied to both curl and clickhouse-cpp dependency handling.
• Curl version update: The core change, updating deps/curl/curl to curl-8.14.0/, successfully reflects the upgrade to curl v8.14.0.
• Trailing slash in deps/curl/curl (Low Severity - Not Commented): The file deps/curl/curl was changed from curl-8.4.0 to curl-8.14.0/. The addition of a trailing slash is a minor stylistic point. While generally harmless as most Unix utilities handle duplicate slashes, it's slightly unconventional if the file is intended to store just the directory name. This was not commented on directly due to its low severity and the review settings.

Merge Readiness

Based on the review of the provided code changes, this pull request appears to be in good shape for merging. The changes are straightforward, contribute to better dependency management, and fulfill the goal of upgrading curl.

As a language model, I am not authorized to approve pull requests. Please ensure that any necessary testing has been completed and that other reviewers have had a chance to look at these changes before merging.

[renecannao]

Why do we create symlinks during make ? symlinks should be well defined

[renecannao]

As before,

Why do we create symlinks during make ? symlinks should be well defined