V3.0 add fedora42 builds

[mirostauder]

implements ticket #4957

[gemini-code-assist]

Hello @mirostauder, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request. This PR, authored by @mirostauder, aims to implement ticket #4957 by adding support for building ProxySQL on Fedora 42. This involves updating the build infrastructure, including Makefiles and Docker Compose configurations, to include targets and services for the new Fedora version. Additionally, several dependencies have been updated, and their build processes adjusted to ensure compatibility with the new build environments.

Highlights

• Add CentOS 10 Builds: Adds build targets and Docker Compose services for CentOS 10, including standard, clang, and debug builds, alongside the Fedora 42 changes.
• Dependency Updates: Updates several key dependencies: clickhouse-cpp (2.3.0 -> 2.5.1), libconfig (1.7.3 -> 1.8), and postgresql (16.3 -> 16.9).
• Build Process Adjustments: Modifies the build steps for updated dependencies in deps/Makefile (e.g., switching libconfig to CMake, adjusting clickhouse-cpp build commands) and updates include/library paths in lib/Makefile and src/Makefile.

Changelog

Click here to see the changelog

• Makefile
  • Added fedora42 and centos10 targets to amd64-fedora and amd64-centos respectively.
  • Added fedora42 and centos10 targets to arm64-fedora and arm64-centos respectively.
• deps/Makefile
  • Updated the build target name for clickhouse-cpp static library from libclickhouse-cpp-lib-static.a to libclickhouse-cpp-lib.a.
  • Changed the clickhouse-cpp tar extraction command to use a wildcard (clickhouse-cpp-*.tar.gz).
  • Added sed commands to the clickhouse-cpp build process to replace <ciso646> with <version> in absl headers.
  • Commented out the patch application for clickhouse/base/wire_format.h in the clickhouse-cpp build.
  • Added sed commands to the mariadb-client build process to replace bool with bbool in ma_global.h and ssl.c.
  • Commented out the autoreconf and ./configure steps for libconfig.
  • Switched the libconfig build process to use cmake with specific options (-DBUILD_SHARED_LIBS=0, -DBUILD_EXAMPLES=0, -DBUILD_TESTS=0, -DBUILD_FUZZERS=0).
  • Updated the libconfig build target name from libconfig/libconfig/lib/.libs/libconfig++.a to libconfig/libconfig/out/libconfig++.a.
  • Added a symbolic link creation step (ln -fsT) for the postgresql source directory.
  • Corrected the rm -rf command for clickhouse-cpp in the cleanall target to use clickhouse-cpp-*/.
• deps/clickhouse-cpp/clickhouse-cpp
  • Updated the clickhouse-cpp version from clickhouse-cpp-2.3.0 to clickhouse-cpp-2.5.1/.
• deps/libconfig/libconfig
  • Updated the libconfig version from libconfig-1.7.3 to libconfig-1.8.
• deps/postgresql/postgresql
  • Updated the postgresql version from postgresql-16.3 to postgresql-16.9/.
• docker-compose.yml
  • Added centos10_build, centos10_clang_build, and centos10_dbg_build services.
  • Added fedora42_build, fedora42_clang_build, and fedora42_dbg_build services.
• include/btree.h
  • Added #include <cstdint>.
• lib/Makefile
  • Added CLICKHOUSE_CPP_PATH and CLICKHOUSE_CPP_IDIR variables for clickhouse-cpp include paths.
  • Updated variable assignments for LIBUSUAL_PATH, LIBUSUAL_IDIR, LIBUSUAL_LDIR, LIBSCRAM_PATH, LIBSCRAM_IDIR, LIBSCRAM_LDIR, POSTGRES_PATH, POSTGRES_IDIR, and POSTGRES_LDIR to use := instead of = and adjusted path formats.
  • Updated the IDIRS variable to use $(CLICKHOUSE_CPP_IDIR) instead of $(CLICKHOUSE_CPP_DIR) and $(CLICKHOUSE_CPP_DIR)/contrib/.
• src/Makefile
  • Updated LIBCONFIG_LDIR to point to the out directory instead of lib/.libs.
  • Updated variable assignments for LIBUSUAL_PATH, LIBUSUAL_IDIR, LIBUSUAL_LDIR, LIBSCRAM_PATH, LIBSCRAM_IDIR, and LIBSCRAM_LDIR to use := instead of = and adjusted path formats.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

New builds arrive,
Fedora, CentOS thrive,
Dependencies update.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily introduces build configurations for Fedora 42 and CentOS 10, which is a valuable addition for broader OS support. The changes also include updates to several key dependencies like clickhouse-cpp, libconfig, and postgresql, along with modifications to their build processes within the deps/Makefile.

Overall, the additions for new OS builds in Makefile and docker-compose.yml seem consistent and well-structured. The updates to dependency versions and their build steps are more involved and raise a few points for discussion, particularly around modifications made via sed.

Good job on updating the build system to support these new distributions and for keeping dependencies up-to-date!

Summary of Findings

• MariaDB bool to bbool Renaming: The sed commands in deps/Makefile that rename bool to bbool in MariaDB client library files are a significant modification to a dependency. This needs clarification on its necessity and potential risks.
• Clarity of Makefile Modifications: Several patches and sed commands in deps/Makefile are commented out. It would be beneficial to understand if these are temporarily disabled or obsolete (in which case they could be removed). Active sed commands could also benefit from comments explaining their purpose.
• Dependency Updates and Build System Changes: The PR updates several dependencies (clickhouse-cpp, libconfig, postgresql) and changes how libconfig is built (from autotools to CMake). These are substantial changes that accompany the new OS support.
• Makefile Best Practices: The switch from = to := for variable assignments in lib/Makefile and src/Makefile is a good improvement.

Merge Readiness

This pull request makes good progress in adding support for Fedora 42 and CentOS 10. The changes to Makefile and docker-compose.yml for the new build targets appear solid.

However, the modifications to dependency build processes, especially the bool to bbool renaming for the MariaDB client library, raise concerns that should be addressed. Clarifying the reasons for commented-out code and adding comments to sed commands in deps/Makefile would also improve long-term maintainability.

I recommend addressing the high severity issue regarding the MariaDB modification and considering the medium severity suggestions before merging. As an AI, I am not authorized to approve pull requests; please ensure further review and approval from the team.

[gemini-code-assist]

These sed commands rename bool to bbool in MariaDB client library source files (ma_global.h and ssl.c). This seems like a significant workaround.

• Could you elaborate on why this renaming is necessary? Is it due to a conflict with C++ bool when compiling C code, or a specific issue with the MariaDB connector version on newer distros/compilers like Fedora 42/CentOS 10?
• Are there potential side effects or risks associated with this change? It might mask underlying type issues or affect compatibility if not handled carefully.

Consider adding a comment explaining the rationale for this modification.

[gemini-code-assist]

This patch for clickhouse-cpp (wire_format.patch) is now commented out. Was this patch incorporated into clickhouse-cpp version 2.5.1, or is it no longer needed for another reason? If it's obsolete, consider removing the line to keep the Makefile clean.

[gemini-code-assist]

These sed commands modify absl headers within clickhouse-cpp to replace <ciso646> with <version>. This is a common fix for C++20 compatibility, as <ciso646> is deprecated/removed.

Could we add a brief comment here explaining why these sed commands are necessary (e.g., "Workaround for C++20 compatibility in absl")? This would improve maintainability for anyone looking at this in the future.

[gemini-code-assist]

These sed commands, which appear to adjust include paths within clickhouse-cpp, are commented out. Are these changes no longer necessary with the updated clickhouse-cpp version or the new CLICKHOUSE_CPP_IDIR definition in lib/Makefile? If they are indeed obsolete, perhaps they could be removed for clarity?

[gemini-code-assist]

The autoreconf and ./configure commands for libconfig are commented out, and a cmake build process is now used (line 274). This is a clear switch in the build system for this dependency.

If the autotools build is no longer an option or intended path for libconfig-1.8, would it be clearer to remove these commented-out lines entirely?

[gemini-code-assist]

The change from = (recursive expansion) to := (simple expansion) for these variable assignments (LIBUSUAL_PATH, LIBSCRAM_PATH, POSTGRES_PATH, etc.) is a good practice. It makes the Makefile's behavior more predictable and can improve parsing performance. Well done for this refinement!

[gemini-code-assist]

Similar to the changes in lib/Makefile, converting these variable assignments from = to := is a positive change for Makefile robustness and clarity. Good catch!