🐛 Remove deprecated --cloud-provider flag from cluster templates #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the deprecated
--cloud-provider=externalflag from all cluster template configurations.Background
The
--cloud-providerflag was completely removed from Kubernetes components in v1.29 (December 2023):kube-apiserverkube-controller-managerkubeletThis flag is no longer supported in newer (v1.33+) Kubernetes versions and will cause the cloud-init to fail if present because the kube-apiserver isn't able to start.
Fixes #1683 and most likely #1719.
References