chore(layout): Remove handler and simplify code structure #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgcrooks-sysdig
force-pushed
the
pcrooks_play
branch
from
db5d194 to
78b1314
Compare
pgcrooks-sysdig
changed the title
pgcrooks-sysdig
force-pushed
the
pcrooks_play
branch
from
78b1314 to
add3d3c
Compare
|
We'll need to update the references in the Terraform provider |
|
I'd remove the whole |
I haven't even looked at that yet to be honest (I only focused on Patcher and Agent). |
- Rely more heavily on goreleaser - Move handler to closed-source (no OSS use-case) - Try to be more "go-thonic" in our layout Ref: SMAGENT-6727
pgcrooks-sysdig
force-pushed
the
pcrooks_play
branch
from
add3d3c to
f1df321
Compare
This removes goreleaser as well as this is now only a library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
cmd.Which issue(s) this PR fixes:
Addresses SMAGENT-6727
Special notes for your reviewer:
TF provider update: sysdiglabs/terraform-provider-sysdig#647