Skip to content

fix(receive): revert CJIT channel size change #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pwltr merged 1 commit into from
Nov 28, 2024
Merged

fix(receive): revert CJIT channel size change #2372

pwltr merged 1 commit into from
Nov 28, 2024

Conversation

@pwltr
Copy link
Collaborator

@pwltr pwltr commented Nov 28, 2024

Description

Partially reverts #2350. It was causing a bug with minimum channel size. Let's leave this code for now. It will be updated later with #1856.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr requested a review from limpbrains November 28, 2024 12:41
@pwltr pwltr merged commit 39613d1 into master Nov 28, 2024
6 of 7 checks passed
@pwltr pwltr deleted the fix/minimum-cjit branch November 28, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@limpbrains limpbrains limpbrains approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pwltr @limpbrains