fix: async beignet wallet #2351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limpbrains
force-pushed
the
async-wallet
branch
3 times, most recently
from
ef9f017 to
2055447
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
limpbrains
force-pushed
the
async-wallet
branch
2 times, most recently
from
95ff8c2 to
4a3cc1c
Compare
limpbrains
force-pushed
the
async-wallet
branch
from
4a3cc1c to
59cfcdf
Compare
pwltr
approved these changes
Nov 22, 2024
Collaborator
pwltr
left a comment
pwltr
left a comment
There was a problem hiding this comment.
Looks good for now, but agree it needs to be improved more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is still not perfect, and we still use sync methods sometimes. I think we can elliminate the remaining issues later
Linked Issues/Tasks
closes #2254 #2202
Type of change
Bug fix
Tests
No test
Screenshot / Video
Insert relevant screenshot / recording
QA Notes