Skip to content

fix: Show Info notification for LNURL-withdraw success #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limpbrains merged 1 commit into from
Nov 7, 2024
Merged

fix: Show Info notification for LNURL-withdraw success #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/screens/Wallets/LNURLWithdraw/Confirm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ const Confirm = ({ route }: LNURLWithdrawProps<'Confirm'>): ReactElement => {
}
dispatch(closeSheet('lnurlWithdraw'));
showToast({
type: 'success',
title: t('lnurl_w_success_title'),
description: t('lnurl_w_success_description'),
type: 'info',
title: t('other:lnurl_withdr_success_title'),
description: t('other:lnurl_withdr_success_msg'),
});
};

Expand Down
2 changes: 1 addition & 1 deletion src/utils/i18n/locales/en/other.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
"string": "Withdraw Requested"
},
"lnurl_withdr_success_msg": {
"string": "Your withdraw was successfully requested."
"string": "Your withdraw was successfully requested. Waiting for payment."
},
"phone_settings": {
"string": "Open Phone Settings"
Expand Down
6 changes: 0 additions & 6 deletions src/utils/i18n/locales/en/wallet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,12 +644,6 @@
"lnurl_w_button": {
"string": "Withdraw"
},
"lnurl_w_success_title": {
"string": "Success"
},
"lnurl_w_success_description": {
"string": "Withdraw Requested Successful"
},
"lnurl_p_title": {
"string": "Pay Bitcoin"
},
Expand Down
7 changes: 0 additions & 7 deletions src/utils/lnurl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,13 +334,6 @@ export const handleLnurlWithdraw = async ({
});
return err(jsonRes.reason);
}

showToast({
type: 'success',
title: i18n.t('other:lnurl_withdr_success_title'),
description: i18n.t('other:lnurl_withdr_success_msg'),
});

return ok('');
} catch (e) {
console.log(e.message);
Expand Down