fix: qr code decoding error message #559
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the error messages displayed when QR code decoding fails to align with iOS implementation. The change improves consistency across platforms by using the same generic error messages for all QR code decode failures.
- Updated error message strings to use more generic wording matching iOS
- Added
isQrCodeparameter tohandleScanfunction to distinguish QR code scans from pasted invoices
| } | ||
|
|
||
| private suspend fun handleScan(result: String) = withContext(bgDispatcher) { | ||
| private suspend fun handleScan(result: String, isQrCode: Boolean) = withContext(bgDispatcher) { |
There was a problem hiding this comment.
The isQrCode parameter is added to the function signature but is not used in the visible code. If this parameter is intended to differentiate between QR code scans and pasted invoices (as mentioned in the PR description), consider implementing conditional logic to use different error messages based on this flag. Otherwise, this parameter appears unused and should be removed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private suspend fun handleScan(result: String) = withContext(bgDispatcher) { | ||
| private suspend fun handleScan(result: String, isQrCode: Boolean) = withContext(bgDispatcher) { |
Check warning
Code scanning / detekt
Function parameter is unused and should be removed. Warning
ovitrif
force-pushed
the
feat/nav3
branch
3 times, most recently
from
e57eef3 to
1eb159f
Compare
Fixes #502
Description
This PR updates the QR code decode message, like iOS
OBS: I noticed that iOS uses the same message to all decode cases. It could be used a generic message to when user paste the invoice
Preview
N/A
QA Notes
Read invalid QR code