Normalize codex auth secret filenames to .json#285
Merged
Conversation
- Normalize auth save/remove/use secret names with a shared .json helper. - Reject backslash path segments consistently across auth secret targets. - Update auth CLI docs and tests for extension auto-append behavior.
CoverageTotal line coverage: 86.54% (59644/68917 lines hit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize codex auth secret filenames to .json
Summary
Normalize
codex-cli authsecret filename handling sosave/remove/useapply one consistent rule: secret files are.json, users may pass names with or without suffix, and existing.jsoninputs are preserved without double-appending.Changes
.jsonin one place.auth save,auth remove, andauth useto use shared validation/normalization behavior.crates/codex-cli/README.mdexamples to reflectname|name.jsonbehavior.Testing
./.agents/skills/nils-cli-verify-required-checks/scripts/nils-cli-verify-required-checks.sh(pass)cargo llvm-cov nextest --profile ci --workspace --lcov --output-path target/coverage/lcov.info --fail-under-lines 85(pass)scripts/ci/coverage-summary.sh target/coverage/lcov.info(pass, total line coverage 86.58%)Risk / Notes
.jsonfilenames; users can re-login/re-save and manually clean old files.