[Map] Deprecate option title from Polygon, Polyline, Rectangle and Circle in favor of infoWindow
#3036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
Kocal
commented
Aug 21, 2025
| @@ -65,7 +65,7 @@ export type MarkerDefinition<BridgeMarkerOptions, BridgeInfoWindowOptions> = Wit | |||
| infoWindow?: Omit<InfoWindowDefinition<BridgeInfoWindowOptions>, 'position'>; | |||
| icon?: Icon; | |||
| /** | |||
| * @deprecated Use "bridgeOptions" instead. | |||
| * @deprecated since Symfony UX Map 2.27, use "bridgeOptions" instead. | |||
There was a problem hiding this comment.
I will open a PR on fabbot to valide the @deprecated since ... format on JS/TS files too.
Kocal
force-pushed
the
map-deprecate-title-on-polygons-polylines-rectangles-circles
branch
from
f41de97 to
c735cde
Compare
Kocal
added a commit
to Kocal/symfony-fabbot
that referenced
this pull request
Aug 21, 2025
Kocal
force-pushed
the
map-deprecate-title-on-polygons-polylines-rectangles-circles
branch
from
c735cde to
0d4eb22
Compare
…` and `Circle` in favor of `infoWindow` While writing E2E tests for Map, I found that our `title` option from `Polygon`, `Polyline`, `Rectangle` and `Circle` was wrongly used, and does not make sense. Using `title` won't add an HTML attribute `title` as I expected, it's not something supported by Google nor Leaflet. Instead, we used it to display a popup, like the `infoWindow` (which is more complete). I suggest deprecating `title` from 2.x and remove it in 3.0.
Kocal
force-pushed
the
map-deprecate-title-on-polygons-polylines-rectangles-circles
branch
from
0d4eb22 to
ae8b7f9
Compare
Kocal
deleted the
map-deprecate-title-on-polygons-polylines-rectangles-circles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing E2E tests for Map, I found that our
titleoption fromPolygon,Polyline,RectangleandCirclewas wrongly used, and does not make sense.Using
titlewon't add an HTML attributetitleas I expected, it's not something supported by Google nor Leaflet.Instead, we used it to display a popup, like the
infoWindow(which is more complete).I suggest deprecating
titlefrom 2.x and remove it in 3.0.