Julia operation #287
Merged
Julia operation #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
reviewed
Mar 19, 2025
|
|
||
|
|
||
|
|
||
| const julia_operations = Vector{Any}(missing, length(SymEngine.symengine_classes)) |
Member
There was a problem hiding this comment.
This is const and gets changed afterwards?
Contributor
Author
There was a problem hiding this comment.
In Julia, the binding is constant, but not its components. (To be honest, I'm not sure this gives any performance improvement here.)
isuruf
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages #286 to make a few lookups more performant:
lambdifywe need the julia symbol for an operationTermInterfaceextension we need the julia operation for a symbolic expressionRather than use
get_symengine_classwe can save a few allocations by usingget_typeto index into a pre-allocated vector.As well, when comparing the symbols to the julia symbols, it was clear a few operations of SymEngine were in need of Julia counterparts.