Skip to content

Cherry pick 3717 3718 fixes to release-4.3 #3719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
# SingularityCE Changelog

## Changes Since Last Release

### Bug fixes

- Don't set ineffective `mode=777` on workdir bind. Fixes error in OCI-mode with
`--workdir` and runc >= 1.2.0.

## 4.3.2 \[2025-06-18\]

## Requirements / Packaging
### Requirements / Packaging

- Ubuntu 20.04 packages dropped - end-of-life.
- EL 10 (RHEL/AlmaLinux/Rocky Linux 10) packages introduced.
2 changes: 1 addition & 1 deletion e2e/actions/actions.go
Original file line number Diff line number Diff line change
@@ -340,7 +340,7 @@ func (c actionTests) actionExecMultiProfile(t *testing.T) {
argv: []string{"--home", "/tmp", c.env.ImagePath, "cat", "/etc/passwd"},
exit: 0,
wantOutputs: []e2e.SingularityCmdResultOp{
e2e.ExpectOutput(e2e.RegexMatch, `^root:x:0:0:\w*:[^:]*:/bin/ash\n`),
e2e.ExpectOutput(e2e.RegexMatch, `^root:x:0:0:[^:]*:[^:]*:/bin/ash\n`),
},
},
}
2 changes: 1 addition & 1 deletion e2e/actions/oci.go
Original file line number Diff line number Diff line change
@@ -308,7 +308,7 @@ func (c actionTests) actionOciExec(t *testing.T) {
argv: []string{"--home", "/tmp", imageRef, "cat", "/etc/passwd"},
exit: 0,
wantOutputs: []e2e.SingularityCmdResultOp{
e2e.ExpectOutput(e2e.RegexMatch, `^root:x:0:0:\w*:[^:]*:/bin/ash\n`),
e2e.ExpectOutput(e2e.RegexMatch, `^root:x:0:0:[^:]*:[^:]*:/bin/ash\n`),
},
},
{
1 change: 0 additions & 1 deletion internal/pkg/runtime/launcher/oci/mounts_linux.go
Original file line number Diff line number Diff line change
@@ -140,7 +140,6 @@ func (l *Launcher) addTmpMounts(mounts *[]specs.Mount) error {
opts := []string{
"rbind",
"relatime",
"mode=777",
}
if !l.cfg.AllowSUID {
opts = append(opts, "nosuid")