add audout:a audout:d aud:a aud:d #636
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yellows8
reviewed
Nov 23, 2023
yellows8
approved these changes
Nov 23, 2023
yellows8
reviewed
Nov 23, 2023
| u64 delay; | ||
| } in = { pid, delay }; | ||
|
|
||
| return serviceDispatchInOut(&g_audoutaSrv, 0, in, *handle_out); |
There was a problem hiding this comment.
This isn't correct for output-handle, see elsewhere.
yellows8
reviewed
Nov 23, 2023
| @@ -83,3 +103,15 @@ u32 audoutGetSampleRate(void); ///< Supported sample rate ( | |||
| u32 audoutGetChannelCount(void); ///< Supported channel count (2 channels). | |||
| PcmFormat audoutGetPcmFormat(void); ///< Supported PCM format (Int16). | |||
| AudioOutState audoutGetDeviceState(void); ///< Initial device state (stopped). | |||
|
|
|||
| Result audoutaRequestSuspendOld(u64 pid, u64 delay, Handle* handle_out); // [1.0.0] - [4.0.0] | |||
|
Any updates on the above review comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application use: I use this in sys-tune to allow for per title volume control whilst keeping the master volume the same.
I've tried to match the style of audout.c/h. It is lacking comments, but i think the function names are descriptive enough.
I have a wrapper for common functions as well, but that probably doesn't belong in libnx :)