Skip to content

Include environment when resolving plugin task #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

award999
Copy link
Contributor

@award999 award999 commented Jul 18, 2025

Description

Provide environment variables when resolveTask is called on a swift-plugin type task.

Issue: #1725

Tasks

  • Required tests have been written
  • Documentation has been updated
  • Added an entry to CHANGELOG.md if applicable

@award999
Copy link
Contributor Author

@adam-fowler it was being set when creating the plugin task: https://github.com/swiftlang/vscode-swift/blob/main/src/tasks/SwiftPluginTaskProvider.ts#L149

but not when resolveTask was called if it was in your tasks.json. Even if not in your tasks.json, there are cases where resolveTask may still get called

@award999 award999 merged commit 58ad058 into swiftlang:main Jul 21, 2025
35 of 36 checks passed
@award999 award999 deleted the resolve-plugin-env branch July 21, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants