[AST] Clear module lookup cache in SourceFile::addTopLevelDecl
#83369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
look-up
branch
2 times, most recently
from
9059042 to
7359f7f
Compare
|
@swift-ci please SourceKit stress test |
Completion unfortunately relies on this to add a top-level decl after the lookup table has been built, make sure the decl gets added to it. We ought to fix completion to avoid needing to mutate the AST like this after-the-fact, but this should work around the issue for now.
|
@swift-ci please test |
hamishknight
requested review from
bnbarham,
rintaro,
hborla,
slavapestov and
xedin
as code owners
|
Trying a different approach: #83613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completion unfortunately relies on this to add a top-level decl after the lookup table has been built, make sure the decl gets added to it. We ought to fix completion to avoid needing to mutate the AST like this after-the-fact, but this should work around the issue for now.