Enable some nice-to-have code formatting rules #3110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
approved these changes
Jun 23, 2025
|
@swift-ci please test |
AnthonyLatsis
commented
Jun 24, 2025
Comment on lines
43
to
50
|
|
||
| // This only makes sense void functions | ||
| if funcDecl.signature.returnClause?.type.as(IdentifierTypeSyntax.self)?.name.text != "Void" { | ||
| if let returnClause = funcDecl.signature.returnClause, | ||
| returnClause.type.as(IdentifierTypeSyntax.self)?.name.text != "Void" | ||
| { | ||
| throw CustomError.message( | ||
| "@addAsync requires an function that returns void" | ||
| ) |
There was a problem hiding this comment.
@ahoppen Had to adjust this because the macro was complaining about a nil result clause not being Void.
There was a problem hiding this comment.
Thanks for adjusting it. Looks good to me.
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.