Tests: Do not use mix of XCTest and Swift Testing #8942
Merged
+265
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci tests |
|
@swift-ci test macOS |
bkhouri
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
bkhouri
commented
Jul 21, 2025
| return try await body(preparedFixture) | ||
| } | ||
| } catch SwiftPMError.executionFailure(let error, let output, let stderr) { | ||
| print("**** FAILURE EXECUTING SUBPROCESS ****") |
There was a problem hiding this comment.
suggestion: we should also consider dumping out the command line arguments.
bkhouri
force-pushed
the
t/main/fix_potential_st_xctest_issue
branch
from
9e717c9 to
4dba299
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/fix_potential_st_xctest_issue
branch
from
4dba299 to
0aca575
Compare
The fixture(..) helper function is being used in XCTest and Swift Testing tests. However, there was a code path that could lead to calling XCTFail(), which is a no-op in Swift Testing. This change rename the functio to fixtureXCTest, and marks it as deprecated with a note indicating to migrate the test to Swift Testing. In addition, create a Swift Testing equivalent of the fixture class that calls the relevant APIs.
bkhouri
force-pushed
the
t/main/fix_potential_st_xctest_issue
branch
from
0aca575 to
1960ad7
Compare
|
@swift-ci test |
|
@swift-ci test windows |
jakepetroules
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixture(..) helper function is being used in XCTest and Swift Testing tests. However, there was a code path that could lead to calling XCTFail(), which is a no-op in Swift Testing.
This change rename the functio to fixtureXCTest, and marks it as deprecated with a note indicating to migrate the test to Swift Testing. In addition, create a Swift Testing equivalent of the fixture class that calls the relevant APIs.