Reduce usage of callback and dispatch methods in favor of async/await #8744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewHoos
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
AndrewHoos
force-pushed
the
moreAsync
branch
2 times, most recently
from
d04eac4 to
f46f956
Compare
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test windows |
plemarquand
reviewed
May 30, 2025
| @@ -97,8 +97,7 @@ public class RepositoryManager: Cancellable { | |||
| repository: RepositorySpecifier, | |||
| updateStrategy: RepositoryUpdateStrategy, | |||
| observabilityScope: ObservabilityScope, | |||
| delegateQueue: DispatchQueue, | |||
| callbackQueue: DispatchQueue | |||
| delegateQueue: DispatchQueue | |||
There was a problem hiding this comment.
#8721 should refactor this so lookup is all async.
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Remove unused callback API Remove unneeded withChecked*Continuation wrappers Use async/await in more tests Remove a usage of DispatchGroup in tests Remove unused callback queues from async methods Removed unused callback methods Moved workspace and plugins to async/await
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce usage of callback and dispatch methods in favor of async/await
Motivation:
Adopt native async/await in more places
Modifications:
Remove unused callback APIs
Remove unneeded withChecked*Continuation wrappers
Use async/await in more tests
Result:
Fewer callbacks and async wrappers and more native async/await