Skip to content

[JExtract/JNI] Add support for variables #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 13, 2025
Merged

[JExtract/JNI] Add support for variables #306

merged 6 commits into from
Jul 13, 2025
+584 −22

Conversation

madsodgaard
Copy link
Contributor

Adds support for both free and member variables. Also supports computed properties, throwing getters and getters/setters.

Boolean getters are now also generated as isX both for FFM and JNI to match Java conventions.

ktoso
ktoso reviewed Jul 12, 2025
View reviewed changes
ktoso
ktoso reviewed Jul 12, 2025
View reviewed changes
ktoso
ktoso approved these changes Jul 12, 2025
View reviewed changes
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, had some comments on this one. Please have a look

@ktoso ktoso merged commit 94d5f34 into swiftlang:main Jul 13, 2025
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsodgaard @ktoso