Enable combining multiple macros on a single type#1935
Open
kperryua wants to merge 3 commits intoswiftlang:experimental/new-codablefrom
Open
Enable combining multiple macros on a single type#1935kperryua wants to merge 3 commits intoswiftlang:experimental/new-codablefrom
kperryua wants to merge 3 commits intoswiftlang:experimental/new-codablefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables combining multiple Codable macros on a single type
Motivation:
At present it isn't actually possible to add
@JSONCodableand@CommonCodableto a single type. It isn't even possible to add@JSONEncodableand@JSONDecodableseparately. The core restriction lies in the fact that each macro takes upon itself the responsibility to generate theCodingFieldstype and its implementation. We need to make the macros "share" that responsibility.Modifications:
We're working with limited information in a macro, especially regarding other macros attached to the same type—basically just its name.
JSONOptimizedCodingField.Result:
@JSONCodableand@CommonCodablecan now be combined in any order. Same for@JSONEncodableand@JSONDecodable(for a result identical to just@JSONCodable).The important parts I care about most are the shared macro interfaces and the resulting output. The actual implementation of the macros could be improved and deduplicated a fair bit. That's not my top priority right now though.
Testing:
Macro expansion verification, including improved diagnostics in swift testing.
Macro integration testing to ensure the generated code works correctly.