Improve String dictionary key strategy tests to verify nested value conversion#1777
Improve String dictionary key strategy tests to verify nested value conversion#1777ShivaHuang wants to merge 1 commit intoswiftlang:mainfrom
Conversation
|
@swift-ci please test |
|
Hi @kperryua, I believe there was some temperate issue in CI system, can you trigger testing again? |
|
@swift-ci please test |
|
It looks like this failure is a CI infrastructure issue rather than a code problem - the Windows runner failed to connect to the Docker daemon (open //./pipe/docker_engine: The system cannot find the file specified), which is unrelated to the changes in this PR. All other recent PRs passed the same Windows (nightly-main) job without issue. Could someone look into the CI runner, or alternatively, would merging main into this PR help trigger a fresh runner assignment? |
039aa54 to
4559998
Compare
- Update decodingDictionaryStringKeyConversionUntouched to use DecodeMe3 values - Update encodingDictionaryStringKeyConversionUntouched to use DecodeMe3 values - Verify String dictionary keys bypass strategy while nested properties apply it - Ensures consistent comprehensive test coverage for dictionary key behavior
4559998 to
67e51e1
Compare
|
The CI failures are unrelated to this PR's changes:
|
|
@swift-ci test |
|
Hi @kperryua, CI is now passing. Friendly ping in case this slipped through. Happy to make any changes if needed! |
Update both tests to use a nested
Codablestruct as the dictionary value.Motivation:
While reviewing #1526, we noticed
encodingDictionaryStringKeyConversionUntouchedanddecodingDictionaryStringKeyConversionUntouchedonly verify that String dictionary keysare preserved, but don't check that key strategies are still correctly applied to nested
struct properties.
Modifications:
Result:
Tests now verify that dictionary keys bypass the strategy AND nested properties apply it
Testing:
encodingDictionaryStringKeyConversionUntoucheddecodingDictionaryStringKeyConversionUntouched