[Subcommands] Ensure an adjacent binary exists before using it #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
approved these changes
Jun 18, 2025
|
@swift-ci test |
|
The error message for Windows seems to be about Predicate's string formatting, but I didn't change code related to that. Is there anything I need to do here to resolve the CI error? This is my first time contributing to Swift, so I don't really know the procedure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling of subcommands in the Swift Driver to ensure correct behavior when the subcommand executable is not adjacent to swift-driver itself. Now, if the adjacent binary doesn't exist, the driver will fall back to a $PATH-based search rather than attempting to run the missing executable (this seems to be the intended behavior based on the comment above this code).
I also expanded the error message for the failure case here.
This change is important because allows users to use subcommands that didn't come bundled with Swift.
Fixes #1932