[lldb] Fix caching, add lookup failures to TSSTyperef's LookupClangType #11066
+81
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
JDevlieghere
approved these changes
Jul 25, 2025
augusto2112
force-pushed
the
cache-failure-find-types
branch
from
d88fac5 to
b0964e9
Compare
|
@swift-ci test |
augusto2112
changed the title
|
@swift-ci test Windows |
augusto2112
force-pushed
the
cache-failure-find-types
branch
from
b0964e9 to
c93c071
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
By profiling LLDB running frame variable in a large application with many many .o files, I noticed that one of the biggest bottlenecks of the operation was looking (and failing) to find a certain potential clang type over and over again. While fixing this I found that we will cache the result, but not the decl context to find that result, which introduces the risk of returning the wrong type if the type is cached, but a different decl context is used.
augusto2112
force-pushed
the
cache-failure-find-types
branch
from
c93c071 to
b60b9ef
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.