🍒[libclang] [Dependency Scanning] Diagnosing Out-Of-Date File System Cache Entries #11064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve Stat Cache Entries (llvm#135703) We have had numerous situations where the negatively stat cached paths are invalidated during the build, and such invalidations lead to build errors. This PR adds an API to diagnose such cases. `DependencyScanningFilesystemSharedCache::diagnoseNegativeStatCachedPaths` allows users of the cache to ask the cache to examine all negatively stat cached paths, and re-stat the paths using the passed-in file system. If any re-stat succeeds, the API emits diagnostics. rdar://149147920 (cherry picked from commit 9ef9167)
llvm#138955) This PR makes a minor modification to make it more stable. The only change is adding a suffix to the path under test. rdar://149147920 (cherry picked from commit 2017831)
…4105) `DependencyScanningFileSystemSharedCache` can currently report out-of-date negatively stat cached paths. This PR enhances the reporting with two modifications. 1. The reported path are now null terminated char arrays instead of `StringRef`s. This way the API's user can avoid copying `StringRef`s to other containers because the char arrays can be used directly. 2. The API now reports out-of-date cache entry due to file size changes. Specifically, we check each file's cached size against the size of the same file on the underlying FS. If the sizes are different, diagnostics will be reported. rdar://152247357 (cherry picked from commit 51d1385)
…try Reporting C-APIs (llvm#10927) This PR implements the C-APIs to report a scanning file system cache's out-of-date entries. The C-APIs contains a function to return a set of file system cache out-of-date entries, functions to facilitate looping through all the entries, and reporting the relevant information from the entries. The APIs are based on llvm#144105. rdar://152247357 (cherry picked from commit 6fbcea6)
…en Computing Out-of-Date File System Cache Entries (llvm#148082) We noticed that when a directory's content changes, its size reported by `status` can change as well. We do not want to include such "false positive" cases. This PR revises the computation so that only regular file size changes are considered out-of-date. rdar://152247357 (cherry picked from commit 5c08bfa)
… C-APIs. (llvm#10992) swiftlang#10927 added a set of C-APIs to report out-of-date scanning file system cache entires. The C-APIs missed their visibility attributes. This PR adds `CINDEX_LINKAGE` to all APIs added by swiftlang#10927. rdar://152247357 (cherry picked from commit d7f7e88)
qiongsiwu
requested review from
Bigcheese,
cyndyishida,
cachemeifyoucan and
owenv
|
@swift-ci please test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks all the relevant PRs to diagnose out-of-date dependency scanning file system cache entries.