Skip to content

Add: Travel Main Screen #445#449

Open
Arham07 wants to merge 2 commits intoswciitg:mainfrom
Arham07:main
Open

Add: Travel Main Screen #445#449
Arham07 wants to merge 2 commits intoswciitg:mainfrom
Arham07:main

Conversation

@Arham07
Copy link

@Arham07 Arham07 commented Oct 19, 2025

CodeAnt-AI Description

Add Travel main screen with bus/ferry cards and switch app background to white

What Changed

  • The Travel page now shows a full "Travel" overview: header with date and notification bell, followed by Bus and Ferry cards that list routes and stop ETAs (e.g., "In 5 mins") with color-coded times.
  • A "More Travel Options" area was added with entries for Administration, Travel Guide, and Cab Sharing, each showing a short descriptive line.
  • The app theme background was changed from the previous darker background to a white scaffold background, making screens appear on white by default.
  • The interactive map and the previous live "next time" card are no longer shown on the Travel page; the custom map style file was removed, so maps no longer use the deleted style asset.
  • New color tokens (dark green and a dull yellow) were added and used to color-code ETA and status indicators on the Travel screen.

Impact

✅ Visible bus and ferry ETAs on Travel screen
✅ White app background across app
✅ More discoverable travel options (Administration, Travel Guide, Cab Sharing)

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai
Copy link

codeant-ai bot commented Oct 19, 2025

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai bot added the size:L This PR changes 100-499 lines, ignoring generated files label Oct 19, 2025
@Arham07
Copy link
Author

Arham07 commented Oct 19, 2025

Hi @vishnu-rai @Imperial-lord @Pawaneet56 kindly review my code from my branch
https://github.com/Arham07/onestop_flutter

i am unable to create PR and to add lable Hacktoberfest-accepted

@codeant-ai
Copy link

codeant-ai bot commented Oct 19, 2025

Pull Request Feedback 🔍

🔒 No security issues identified
⚡ Recommended areas for review

  • Global Background Change
    The PR hardcodes the app scaffold background to kWhite (light theme). Setting a global white scaffold may cause contrast and readability regressions for screens/components that were designed for the previous darker kBackground (e.g., status bars, cards, overlays). It also removes any dark-mode support — consider verifying all screens and widgets remain accessible and visually correct after this change.

  • Missing interactivity & accessibility
    Rows that look interactive (Bus/Ferry headers, "More Travel Options" entries) lack tap handlers/InkWell and semantic labels. No visual feedback or onTap/navigation is implemented. Images also lack explicit size/fallback which can cause layout shifts or runtime errors if assets are missing.

  • Accessibility / Contrast
    The new kYellowDullColor may not provide sufficient contrast against the updated white scaffold background — verify its contrast ratio against kWhite and UI surfaces where it will be used (badges, small labels, icons). If the color is used to convey status, low contrast can make the information hard to perceive for users with low vision.

  • Hard-coded date
    The date string is hard-coded instead of being generated from the device locale/time. This will become stale and breaks localization/timezone expectations.

  • Repeated UI / Maintainability
    Multiple Card-like Containers (bus, ferry, options) duplicate padding, decoration and layout. This increases maintenance burden and risk of inconsistent updates. Consider extracting a reusable widget to reduce duplication.

@codeant-ai
Copy link

codeant-ai bot commented Oct 19, 2025

CodeAnt AI finished reviewing your PR.

@Arham07
Copy link
Author

Arham07 commented Oct 19, 2025

attaching screenshots

Simulator Screenshot - iPhone 15 Pro Max - 2025-10-19 at 04 57 06 Simulator Screenshot - iPhone 15 Pro Max - 2025-10-19 at 04 57 10

@Arham07
Copy link
Author

Arham07 commented Oct 20, 2025

I have made changes according to Ai chatbot points, please note that I made UI for white theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants