Skip to content

feat(es/compiler): Merge nullish_coalescing #10974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(es/compiler): Merge nullish_coalescing #10974

wants to merge 1 commit into from
+13 −262

Conversation

CodeMan62
Copy link
Contributor

@CodeMan62 CodeMan62 commented Aug 4, 2025 •
edited
Loading

Description:
merges nullish_coalescing into compiler

BREAKING CHANGE:
N/A

Related issue:
This is a par of #10913

@CodeMan62 CodeMan62 requested review from a team as code owners August 4, 2025 17:20
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3a56eca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10974 will degrade performances by 2.95%

Comparing CodeMan62:nullish_coalescing/compiler (8039527) with main (91c6039)

Summary

❌ 1 regressions
✅ 139 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ es2020_nullish_coalescing 297.3 µs 306.4 µs -2.95%

kdy1
kdy1 requested changes Aug 6, 2025
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix CI and the perf regression?

@CodeMan62 CodeMan62 marked this pull request as draft August 6, 2025 16:17
@socket-security Socket Security
Copy link

socket-security bot commented Aug 6, 2025 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@CodeMan62 CodeMan62 force-pushed the nullish_coalescing/compiler branch from c41f09b to 7c9b3b7 Compare August 6, 2025 17:42
@CodeMan62
Copy link
Contributor Author

CodeMan62 commented Aug 7, 2025 •
edited
Loading

strange that when running benchmarks locally there is no regression but there is still?

@CodeMan62 CodeMan62 force-pushed the nullish_coalescing/compiler branch from 8039527 to 3a56eca Compare August 14, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeMan62 @kdy1