Skip to content

pref(es/minifier): less clone atom #10967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jul 31, 2025

No description provided.

@bvanjoi bvanjoi requested review from a team as code owners July 31, 2025 10:29
Copy link

changeset-bot bot commented Jul 31, 2025

⚠️ No Changeset found

Latest commit: 82e2208

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Jul 31, 2025

CodSpeed Performance Report

Merging #10967 will degrade performances by 4.44%

Comparing bvanjoi:use-hashed-id (82e2208) with main (862e70d)

Summary

❌ 7 regressions
✅ 133 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/minifier/libs/echarts 1.5 s 1.6 s -2.97%
es/minifier/libs/jquery 95.4 ms 97.6 ms -2.23%
es/minifier/libs/terser 345.1 ms 359.8 ms -4.11%
es/minifier/libs/three 637.1 ms 666.6 ms -4.41%
es/minifier/libs/typescript 3.8 s 3.8 s -2.01%
es/minifier/libs/victory 848.4 ms 887.8 ms -4.44%
es/minifier/libs/vue 140.6 ms 146.3 ms -3.9%

@CPunisher
Copy link
Member

CPunisher commented Jul 31, 2025

Is it correct if two Id have conflicted HashId? Under the circumstance, for example, will self.data.vars.get(&name.hashed_id()) return the usage data of other Id's?

@kdy1
Copy link
Member

kdy1 commented Jul 31, 2025

It’s possible and I think this approach is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants