Remove deprecated PF context measure from ContextMeasureSimple #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NBA.com API no longer returns data when using "PF" (Personal Fouls) as a context measure for the shotchartdetail endpoint. Other context measures like FGA, FGM, and PTS continue to work correctly. Fixes swar#600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
PF(Personal Fouls) context measure from theContextMeasureSimpleclass as it has been deprecated by the NBA.com API.Issue
Fixes #600
Details
The NBA.com API endpoint for
shotchartdetailno longer returns data when usingPFas a context measure. Other context measures such asFGA,FGM,PTS,EFG_PCT, andTS_PCTcontinue to function correctly.This appears to be a backend change by the NBA, as Personal Fouls are not a relevant metric for filtering shot chart data (which focuses on shooting statistics).
Changes
pf = "PF"from theContextMeasureSimpleclass insrc/nba_api/stats/library/parameters.pyTesting
Users who were experiencing issues with the
PFcontext measure returning no data should no longer be able to use this deprecated parameter, preventing confusion and API errors.