Fix critical pod readiness check bug causing immediate task termination#225
Open
ThomasBlock wants to merge 2 commits into
Open
Fix critical pod readiness check bug causing immediate task termination#225ThomasBlock wants to merge 2 commits into
ThomasBlock wants to merge 2 commits into
Conversation
The pod readiness check logic was incorrectly using PodReady conditions instead of checking pod phase status. This caused pods to be immediately terminated (within 7-9 seconds) before containers could start. Changes: - Replace incorrect condition-based readiness check with pod phase check - Use PodRunning phase status (correct for batch jobs without readiness probes) - Fixed in 3 locations: ubi_service.go (2x) and space_service.go (1x) This bug was causing all GPU/ZK tasks to fail immediately as the wait loop would error out, triggering namespace deletion in the defer cleanup function. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pod readiness check logic was incorrectly using PodReady conditions instead of checking pod phase status. This caused pods to be immediately terminated (within 7-9 seconds) before containers could start.
Changes:
This bug was causing all GPU/ZK tasks to fail immediately as the wait loop would error out, triggering namespace deletion in the defer cleanup function.
🤖 Generated with Claude Code