Skip to content

Conversation

Lunkers
Copy link
Contributor

@Lunkers Lunkers commented Sep 9, 2025

Description

Currently, audio mix presets are tied to the central encore configuration. This is fine in cases where configuration is decoupled from deployments; however, many organizations unfortunately don't set up external configuration servers. In these cases, users cannot add or modify audio mix presets without requiring a new deployment of the service..

This PR adds the option of specifying audio-mix-preset-location under encore-properties.encoding. This allows users to decouple mix presets from the central config, the same way encore currently handles transcoding profiles.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Integration and service-level tests.

Checklist:

  • I confirm that I wrote and/or have the right to submit the contents of my PR, by agreeing to the Developer Certificate of Origin (see https://github.com/svt/open-source-project-template/blob/master/docs/CONTRIBUTING.adoc[docs/CONTRIBUTING]).
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)

@Lunkers Lunkers force-pushed the pr-externalize-audio-mix branch from 6249e67 to f0fec12 Compare September 9, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant