Fix: Model loader callback consistency #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker image for this PR is ready: docker pull ghcr.io/sveneisenschmidt/n8n-openai-bridge:pr-31Test it locally: docker run -d -p 3333:3333 -e BEARER_TOKEN=test-token ghcr.io/sveneisenschmidt/n8n-openai-bridge:pr-31 |
Resolves #29 Problem: - N8nApiModelLoader fired watch callback on every poll regardless of changes - JsonFileModelLoader only fired callback when file content changed - This inconsistency blocked proper solution for #30 Changes: - Added getModelsHash() method to base ModelLoader class - Both loaders now use consistent lastHash variable name - N8nApiModelLoader now compares model hash before firing callback - JsonFileModelLoader switched from file hash to model hash comparison - Updated tests to reflect new behavior Benefits: - Callbacks only fire when models actually change - Consistent behavior across all model loaders - Enables proper webhook notifications for model changes - Formatting changes (whitespace) no longer trigger reloads
sveneisenschmidt
force-pushed
the
fix/model-loader-callback-consistency
branch
from
b38e65a to
a0719f6
Compare
|
Docker image for this PR is ready: docker pull ghcr.io/sveneisenschmidt/n8n-openai-bridge:pr-31Test it locally: docker run -d -p 3333:3333 -e BEARER_TOKEN=test-token ghcr.io/sveneisenschmidt/n8n-openai-bridge:pr-31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29
Problem
The two model loaders had inconsistent behavior when watching for changes:
This inconsistency blocks a proper solution for #30 (webhook notifications on model changes).
Changes
Base ModelLoader Class
lastHashproperty for change trackinggetModelsHash(models)method for consistent hash calculation across all loadersN8nApiModelLoader
getModelsHash()from base class instead of firing callback on every polllastModelsHashtolastHashfor consistencyJsonFileModelLoader
getModelsHash()from base classgetFileHash()method (no longer needed)Tests
lastHashinstead oflastModelsHashBenefits
Testing
All 367 tests pass with 95.82% code coverage.