Skip to content

chore: remove some todos #16515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: remove some todos #16515

wants to merge 4 commits into from
+75 −51

Conversation

Ocean-OS
Copy link
Member

@Ocean-OS Ocean-OS commented Jul 27, 2025 •
edited
Loading

This removes some // TODO comments. It shouldn't change much behavior-wise, as it's mostly tweaks to types.
Since this does change an AST node's type, I will update #16188 once this is merged.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 528ff39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-svelte-16515-svelte.vercel.app/

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16515

7nik
7nik reviewed Jul 28, 2025
View reviewed changes
packages/svelte/src/compiler/phases/3-transform/client/visitors/CallExpression.js
@@ -82,7 +82,9 @@ export function CallExpression(node, context) {
['debug', 'dir', 'error', 'group', 'groupCollapsed', 'info', 'log', 'trace', 'warn'].includes(
node.callee.property.name
) &&
node.arguments.some((arg) => arg.type !== 'Literal') // TODO more cases?
node.arguments.some(
(arg) => arg.type === 'SpreadElement' || context.state.scope.evaluate(arg).values.has(UNKNOWN)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evaluation of SpreadElement will result in UNKNOWN anyway, so the first check can be removed, right?
And maybe it's cleaner to add has/is_unknown prop-flag to Evaluation and use it here.

@Rich-Harris
Copy link
Member

I actually don't think we can rename Comment without it being a breaking change (for e.g. svelte-ast-print or anything else that operates on the AST). Even though we've stated that it's subject to change, I don't think we should change things like this unless we really need to. It's already disambiguated enough in my view — AST.Comment vs e.g. ESTree.Comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7nik 7nik 7nik left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ocean-OS @Rich-Harris @7nik