Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/witty-kids-fail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: avoid writing remote function bundle to disk when treeshaking prerendered queries
8 changes: 4 additions & 4 deletions packages/kit/src/exports/vite/build/build_remote.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,10 @@ export async function treeshake_prerendered_remotes(out, manifest_data, metadata
input[prefix + remote.hash] = remote_file;
}

const bundle = await vite.build({
const bundle = /** @type {import('vite').Rollup.RollupOutput} */ (await vite.build({
configFile: false,
build: {
write: false,
ssr: true,
rollupOptions: {
external: (id) => {
Expand All @@ -114,11 +115,10 @@ export async function treeshake_prerendered_remotes(out, manifest_data, metadata
input
}
}
});
}));

// @ts-expect-error TypeScript doesn't know what type `bundle` is
for (const chunk of bundle.output) {
if (chunk.name.startsWith(prefix)) {
if (chunk.type === 'chunk' && chunk.name.startsWith(prefix)) {
fs.writeFileSync(`${dir}/${chunk.fileName.slice(prefix.length)}`, chunk.code);
}
}
Expand Down
7 changes: 7 additions & 0 deletions packages/kit/test/apps/basics/test/server.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -768,3 +768,10 @@ test.describe('$app/environment', () => {
expect(code).not.toContain('browser');
});
});

test.describe('remote functions', () => {
test("doesn't write bundle to disk when treeshaking prerendered remote functions", () => {
test.skip(!!process.env.DEV, 'skip when in dev mode');
expect(fs.existsSync(path.join(root, 'dist'))).toBe(false);
});
});
Loading