Skip to content

chore: Halve the number of routes necessary to serve prerendered files on Vercel #13989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Previously, for a route like /blog/[slug] where /blog/first-post is prerendered with trailingSlash: 'always', we output the following routing:

{
	"version": 3,
	"routes": [
                 {
                         "src": "/blog/first-post/",
                         "dest": "/blog/first-post"
                 },
		{
			"src": "/blog/first-post",
			"status": 308,
			"headers": {
				"Location": "/about/"
			}
		},
		...
	],
	"overrides": {
		"blog/first-post/index.html": {
			"path": "blog/first-post"
		}
	}
}

The original code from #7725 assumes that the first routing entry is necessary to get /blog/first-post/ to match the path from the overrides, but it's not -- both blog/first-post and blog/first-post/ match this path, so all we really have to do is make sure we deploy a redirect route that sends the user to the correct variant. The new version of this routing code looks like this:

{
	"version": 3,
	"routes": [
		{
			"src": "/blog/first-post",
			"status": 308,
			"headers": {
				"Location": "/about/"
			}
		},
		...
	],
	"overrides": {
		"blog/first-post/index.html": {
			"path": "blog/first-post"
		}
	}
}

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jul 11, 2025

🦋 Changeset detected

Latest commit: b8b1758

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github changed the title chore: Halve the number of routes necessary to serve prerendered file… chore: Halve the number of routes necessary to serve prerendered files on Vercel Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant