Skip to content

fix(term): make sure that libdillimpl include uses "" marks#234

Open
sleeptightAnsiC wants to merge 1 commit intosustrik:masterfrom
sleeptightAnsiC:term_fix_include
Open

fix(term): make sure that libdillimpl include uses "" marks#234
sleeptightAnsiC wants to merge 1 commit intosustrik:masterfrom
sleeptightAnsiC:term_fix_include

Conversation

@sleeptightAnsiC
Copy link
Copy Markdown

@sleeptightAnsiC sleeptightAnsiC commented Jan 7, 2025

I attempted to compile libdill without build system
(just cc every source file and link it by hand)
and found out that compilation of libdill/term.c fails due to:

$ cc term.c -o term.o -c ; cc --version ; uname -srm
term.c:31:10: fatal error: libdillimpl.h: No such file or directory
   31 | #include <libdillimpl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
cc (GCC) 14.2.1 20240910
Linux 6.12.8-arch1-1 x86_64

This is caused by the fact that include here uses <> instead of ""

libdill/term.c

Line 31 in 32d0e8b

#include <libdillimpl.h>

And this is what PR fixes.
It was the only place where said include was using wrong marks.

This fixes issue where compiling libdill/term.c fails
when done by hand (without build system)
due to searching for libdillimpl.h in system-headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant