feat: Serbian translation for v3.4.1#41
Conversation
|
@igorhrcek thanks for the PR. Please could you Allow edits from maintainers or update the branch yourself? |
bytestream
left a comment
bytestream
left a comment
There was a problem hiding this comment.
Thanks for your efforts on this. The GitHub workflow has identified some problems in the translation files. I've highlighted a couple in my review.
You can test the changes locally by running:
git clone https://github.com/supportpal/language-files en
composer require --dev supportpal/language-tools
php vendor/bin/language-tools compare en .Following the above, you can also run the below to automatically correct some of the issues. I'd ask that you carefully review the changes though as it will remove some of your translations and replace them with the English version:
php vendor/bin/language-tools sync en .| "possible_permission_issue" => "[UPOZORENJE] Izgleda da ovu komandu pokrećete kao root ili kao drugi korisnik. Komandu mora da izvrši pravi korisnik da bi veb server imao mogućnost čitanja i pisanja u sistemu nakon toga.", | ||
| "error_and_empty_database" => "Došlo je do greške. Možda će biti neophodno da ispraznite bazu podataka pre ponovnog pokretanja.", | ||
| "login_with_details" => "Možete se prijaviti koristeći ranije navedene detalje.", | ||
| "command_not_available" => "Komanda nije dostupna. Ako mislite da je došlo do greške, pokrenite „php artisan cache: clear“, a zatim ponovo pokrenite ovu komandu.", |
There was a problem hiding this comment.
I believe „ and “ should be an ASCII "
| "possible_permission_issue" => "[UPOZORENJE] Izgleda da ovu komandu pokrećete kao root ili kao drugi korisnik. Komandu mora da izvrši pravi korisnik da bi veb server imao mogućnost čitanja i pisanja u sistemu nakon toga.", | ||
| "error_and_empty_database" => "Došlo je do greške. Možda će biti neophodno da ispraznite bazu podataka pre ponovnog pokretanja.", | ||
| "login_with_details" => "Možete se prijaviti koristeći ranije navedene detalje.", | ||
| "command_not_available" => "Komanda nije dostupna. Ako mislite da je došlo do greške, pokrenite „php artisan cache: clear“, a zatim ponovo pokrenite ovu komandu.", |
There was a problem hiding this comment.
cache: clear should be cache:clear
| * 2.1.0 | ||
| */ | ||
| "ticket_brand" => "Ticket brand", | ||
| "Tiket_brand" => "Tiket brand", |
There was a problem hiding this comment.
Please could you fix lines like this which are causing the tests to fail. The correct version should be:
"ticket_brand" => "Tiket brand",Only the value on the right hand side between the quotes should be modified.
2 participants
No description provided.