Skip to content

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Aug 11, 2025

This PR adds Spanish localization support to the USB Terminal Android app by introducing a new resource file containing translations for all existing user-facing strings.

Changes Made

  • Created app/src/main/res/values-es/strings.xml with 43 translated strings
  • Preserved all formatting elements including:
    • Placeholder variables (%d for baud rate values)
    • Newline escape sequences (\n)
    • XML structure and comments
  • Excluded the non-translatable next_line key as intended (marked with translatable="false" in English)
  • Fixed the embedded quotes issue in breceiver_info_usb_permission_granted translation

Translation Quality

All translations maintain the technical accuracy of the original English strings while being naturally readable in Spanish. Key technical terms like "Arduino", "USB", and "baud rate" are properly localized.

Validation

  • ✅ XML structure is well-formed
  • ✅ All 43 translatable English strings have Spanish counterparts
  • ✅ No missing or extra translations
  • ✅ All %d placeholders preserved exactly
  • ✅ All \n newline escapes maintained
  • ✅ Non-translatable next_line correctly omitted

The app will now automatically display Spanish text for users with Spanish locale settings, falling back to English for any untranslated strings (none in this case).

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx1536m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/gradle-daemon-main-8.13.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/agents/gradle-instrumentation-agent-8.13.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.13 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@superus8r
Copy link
Owner

@copilot The proposal looks good, please proceed.

@Copilot Copilot AI changed the title [WIP] Add Spanish (es) localization resources Add Spanish (es) localization resources Aug 11, 2025
@Copilot Copilot AI requested a review from superus8r August 11, 2025 14:51
Copilot finished work on behalf of superus8r August 11, 2025 14:51
Copy link
Author

Copilot AI commented Aug 11, 2025

@copilot The proposal looks good, please proceed.

Thank you! The Spanish localization has been completed successfully. The values-es/strings.xml file contains all 43 translatable strings with accurate Spanish translations, proper preservation of formatting elements (%d placeholders, \n escapes), and correct exclusion of the non-translatable next_line resource. The app will now automatically display Spanish text for users with Spanish locale settings. (240b4df)

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of superus8r August 11, 2025 14:56
Copy link

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.48%. Comparing base (5933ac3) to head (240b4df).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #55   +/-   ##
==========================================
  Coverage      60.48%   60.48%           
  Complexity        96       96           
==========================================
  Files             29       29           
  Lines            620      620           
  Branches          89       89           
==========================================
  Hits             375      375           
  Misses           199      199           
  Partials          46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants