fix: for backport release 9.3 #275
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| echo "Unsupported architecture: $ARCH" && exit 1; \ | ||
| fi | ||
| RUN unzip jre.zip | ||
| RUN mv jre-15.0.1 jre || mv jre-15.0.1-linux-aarch/jre-15.0.1 jre |
There was a problem hiding this comment.
The ARM JRE extraction path appears inconsistent with the download URL. The command attempts to use jre-15.0.1-linux-aarch/jre-15.0.1 but the download URL uses -linux-arm. Consider updating the extraction path to match the archive structure, likely jre-15.0.1-linux-arm/jre-15.0.1 or simply jre-15.0.1-linux-arm. This mismatch could cause Docker build failures on ARM architectures.
| RUN mv jre-15.0.1 jre || mv jre-15.0.1-linux-aarch/jre-15.0.1 jre | |
| RUN mv jre-15.0.1 jre || mv jre-15.0.1-linux-arm/jre-15.0.1 jre |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| if [ ! -z $API_KEYS ] | ||
| then | ||
| echo "api_keys: $API_KEYS" >> $CONFIG_FILE |
There was a problem hiding this comment.
The environment variable check [ ! -z $API_KEYS ] doesn't properly handle API keys containing spaces, which could lead to unexpected behavior. Consider using quoted variables like [ ! -z "$API_KEYS" ] to correctly handle values with spaces. This same issue appears in all the other environment variable checks in this script.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlebuild.gradle, please make sure to add themin
implementationDependencies.json.git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.OneMillionUsersTestRemaining TODOs for this PR